Conversation
Member
|
Oh dang didn't realize we were doing any string matching on the output of the demangler. |
plafosse
approved these changes
Apr 10, 2026
Member
Author
|
Yea its for extern stuff, maybe there is some metadata in the ELF/Mach-O we can use instead of just doing that, but 🤷 |
Member
|
I feel like we need to be using the same string or we need a static assert to ensure stuff like this doesn't happen. Also I think this might fail if our own demangler is turned off and the Generic Demangler kicks in. |
Member
Author
|
I think I will do a follow up PR to make this specific part more robust, for now this is good to fix the regression for 5.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue stems from the gnu3 demangler changing in 260ca61
Fixes #8080